Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include_optional_linkage_data with joins #1450

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix include_optional_linkage_data with joins #1450

merged 1 commit into from
Apr 18, 2024

Commits on Feb 16, 2024

  1. Fix include_optional_linkage_data with joins 

    When the user adds a join in `records`, it confuses `get_join_arel_node`
because it finds the same number of joins before & after adding a join
for `include_optional_linkage_data` (or equivalently for
`always_include_*_linkage_data`).

This commit falls back to searching the existing arel nodes for a
compatible join and uses that if found.
    @pjungwir
    pjungwir committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d8978c2 View commit details
    Browse the repository at this point in the history