Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extract test app #1419

Closed
wants to merge 2 commits into from
Closed

test: extract test app #1419

wants to merge 2 commits into from

Conversation

bf4
Copy link
Collaborator

@bf4 bf4 commented Oct 27, 2023

I created new rails engine with a dummy app and copied that into our
test folder in the same place, test/dummy. I suspect that using the
incantantations in the generated test/dummy and test/test_helper.rb will
help get us to Rails 7.1 test parity.

rails plugin new TestApp --mountable

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
    • except for Rails 7.1, which is already failing
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@bf4
Copy link
Collaborator Author

bf4 commented Nov 1, 2023

was trying to solve the problem which #1420 solves, so closing since this is interesting, but not needed

@bf4 bf4 closed this Nov 1, 2023
@bf4 bf4 deleted the extract_dummy_app branch November 1, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant