Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement allow_transactions feature #1410

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

revis0r
Copy link
Contributor

@revis0r revis0r commented Jul 19, 2023

You have a configuration optionallow_transactions, but looks like implementation is missing.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

You have a configuration option`allow_transactions`, but looks like implementation is missing.
@lgebhardt lgebhardt merged commit a3a2a7a into cerebris:master Sep 19, 2023
28 checks passed
@lgebhardt
Copy link
Member

Thanks @revis0r

nginz pushed a commit to nginz/jsonapi-resources that referenced this pull request Dec 21, 2023
You have a configuration option`allow_transactions`, but looks like implementation is missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants