chore: prefer not introducing assign_attributes from ActiveModel

cerebris · Jan 22, 2024 · 85c067c · 85c067c
1 parent 4e65502
commit 85c067c
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/lib/jsonapi/resource_common.rb b/lib/jsonapi/resource_common.rb
@@ -1200,16 +1200,12 @@ def define_relationship_methods(relationship_name, relationship_klass, options)
       def define_foreign_key_setter(relationship)
         if relationship.polymorphic?
           define_on_resource "#{relationship.foreign_key}=" do |v|
-            _model.assign_attributes(
-              relationship.foreign_key => v[:id],
-              relationship.polymorphic_type => v[:type]&.to_s&.classify
-            )
+            _model.public_send("#{relationship.foreign_key}=", v[:id])
+            _model.public_send("#{relationship.polymorphic_type}=", v[:type]&.to_s&.classify)
           end
         else
           define_on_resource "#{relationship.foreign_key}=" do |value|
-            _model.assign_attributes(
-              relationship.foreign_key => value
-            )
+            _model.public_send("#{relationship.foreign_key}=", value)
           end
         end
         relationship.foreign_key