Merge pull request #47 from catchpoint/apply_command_issue

Fixed a minor bug to detect changes correctly for optional fields on running "terraform apply" command.
catchpoint · Jul 17, 2024 · 8210641 · 8210641
2 parents 444e833 + 2882c3b
commit 8210641
Show file tree

Hide file tree

Showing 11 changed files with 6 additions and 57 deletions.
diff --git a/catchpoint/resource_api_test_type.go b/catchpoint/resource_api_test_type.go
@@ -1109,13 +1109,6 @@ func resourceApiTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("status", testNew["status"])
 	d.Set("test_script", testNew["test_script"])
 	d.Set("test_script_type", testNew["test_script_type"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("request_settings", testNew["request_settings"])
-	d.Set("insights", testNew["insights"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_bgp_test_type.go b/catchpoint/resource_bgp_test_type.go
@@ -464,8 +464,6 @@ func resourceBgpTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("end_time", testNew["end_time"])
 	d.Set("status", testNew["status"])
 	d.Set("prefix", testNew["test_url"])
-	d.Set("label", testNew["label"])
-	d.Set("alert_settings", testNew["alert_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_dns_test_type.go b/catchpoint/resource_dns_test_type.go
@@ -677,11 +677,6 @@ func resourceDnsTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("test_domain", testNew["test_url"])
 	d.Set("query_type", testNew["query_type"])
 	d.Set("dns_server", testNew["dns_server"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_ping_test_type.go b/catchpoint/resource_ping_test_type.go
@@ -612,11 +612,6 @@ func resourcePingTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("end_time", testNew["end_time"])
 	d.Set("status", testNew["status"])
 	d.Set("test_location", testNew["test_url"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_playwright_test_type.go b/catchpoint/resource_playwright_test_type.go
@@ -1130,13 +1130,6 @@ func resourcePlaywrightTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("status", testNew["status"])
 	d.Set("test_script", testNew["test_script"])
 	d.Set("test_script_type", testNew["test_script_type"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("request_settings", testNew["request_settings"])
-	d.Set("insights", testNew["insights"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_puppeteer_test_type.go b/catchpoint/resource_puppeteer_test_type.go
@@ -1140,13 +1140,6 @@ func resourcePuppeteerTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("status", testNew["status"])
 	d.Set("test_script", testNew["test_script"])
 	d.Set("test_script_type", testNew["test_script_type"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("request_settings", testNew["request_settings"])
-	d.Set("insights", testNew["insights"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_ssl_test_type.go b/catchpoint/resource_ssl_test_type.go
@@ -625,11 +625,6 @@ func resourceSslTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("test_location", testNew["test_url"])
 	d.Set("enforce_certificate_pinning", testNew["enforce_certificate_pinning"])
 	d.Set("enforce_certificate_key_pinning", testNew["enforce_certificate_key_pinning"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	log.Printf("[DEBUG RESOURCE] %v", d)
 

diff --git a/catchpoint/resource_traceroute_test_type.go b/catchpoint/resource_traceroute_test_type.go
@@ -612,11 +612,6 @@ func resourceTracerouteTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("end_time", testNew["end_time"])
 	d.Set("status", testNew["status"])
 	d.Set("test_location", testNew["test_url"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_transaction_test_type.go b/catchpoint/resource_transaction_test_type.go
@@ -1139,13 +1139,6 @@ func resourceTransactionTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("status", testNew["status"])
 	d.Set("test_script", testNew["test_script"])
 	d.Set("test_script_type", testNew["test_script_type"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("request_settings", testNew["request_settings"])
-	d.Set("insights", testNew["insights"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/catchpoint/resource_web_test_type.go b/catchpoint/resource_web_test_type.go
@@ -1143,13 +1143,6 @@ func resourceTestRead(d *schema.ResourceData, m interface{}) error {
 	d.Set("start_time", testNew["start_time"])
 	d.Set("end_time", testNew["end_time"])
 	d.Set("status", testNew["status"])
-	d.Set("label", testNew["label"])
-	d.Set("thresholds", testNew["thresholds"])
-	d.Set("request_settings", testNew["request_settings"])
-	d.Set("insights", testNew["insights"])
-	d.Set("schedule_settings", testNew["schedule_settings"])
-	d.Set("alert_settings", testNew["alert_settings"])
-	d.Set("advanced_settings", testNew["advanced_settings"])
 
 	return nil
 }

diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,9 @@
+# v1.2.0
+
+BUG FIXES
+
+* Fixed a minor bug to detect changes correctly for optional fields on running "terraform apply" command.
+
 # v1.0.1
 
 Catchpoint internal testing: