[feat]: Overhaul private key management #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the
privateKeyis loaded has been updated. The new implementation:privateKeyon the config file. This is for backwards compatibility and for ease of development. A warning to the console is printed if this method is used.privateKeyconfiguration is specified, theprivateKeyis loaded from the environment variableUNDERWRITER_PRIVATE_KEYusing theenvprivateKeyloader. (The variable name is customizable for advanced users.)privateKeyloaders may be implemented (configured viaglobal.privateKey.loader). This boils down to implementing a class with an async function that returns aprivateKeyas a hex string. The returnedprivateKeyformat is validated to avoid hard to debug implementation errors.This issue is a mirror of catalystdao/generalised-relayer#27