Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to onboarding reproduction logs #2610

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

andrewxucs
Copy link
Contributor

Successfully reproduced steps 1 and 2 of onboarding

Setup:
OS: mac OS Sonoma 14.6.1
Chip: Apple M1
Memory: 8 GB

Problems Encountered:

  1. the command "wget" is actually not pre-installed in my computer, so I just used "curl -o". It works just as well. Since this issue is easy to resolve I think it is not necessary to mention it in the guide
  2. threads aborted during indexing. I tried again after a system update (I didn't actually update because of this onboarding) and then it somehow worked
  3. mvn clean package worked but it took a very long time (approximately 40 minutes on my side). I think telling other hackers how long they should expect to wait is a good idea, but that may not improve readability

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (4ef1de0) to head (4201fc4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2610   +/-   ##
=========================================
  Coverage     65.56%   65.56%           
  Complexity     1479     1479           
=========================================
  Files           225      225           
  Lines         13012    13012           
  Branches       1551     1551           
=========================================
  Hits           8531     8531           
  Misses         3953     3953           
  Partials        528      528           
Flag Coverage Δ
65.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool merged commit 5082e53 into castorini:master Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants