rework band info creation to make sure output contains all selector values #108
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
There was a problem hiding this comment.
Thanks for tackling this! I have to confess I find the logic sort of hard to follow (probably due to the way I set this up 🙈), so I quickly wrote up some tests to compare what's happening against main.
Want to merge these in? #109
| }) | ||
| combinedBands = newCombinedBands | ||
| }) | ||
| Object.keys(selector).forEach((key) => { |
There was a problem hiding this comment.
This feels like the meat of the fix! I think I'm confused by the rest of the diff above -- what is that achieving?
There was a problem hiding this comment.
no functional changes with the rewrite above so reverted to keep this update a little cleaner! i wasn't parsing the reducer well last night
There was a problem hiding this comment.
ooh gotcha. if the reducer was feeling more readable to you with the changes, totally open to leaving em in!
Add test for `getBandInformation()`
This fixes the issue we were seeing when trying to select down a store containing multiple bands, but also other selectors that need to be passed through. This should now include all the selectors with each band (eg elapsed_time, ids, etc)
I've tested this with the seaweed viewer and it seems to behave correctly. It's also working with OAE.