build!: use setuptools-scm to declare version #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
requested changes
Jul 15, 2024
src/therapy/__init__.py
Outdated
| APP_ROOT: Path = Path(__file__).resolve().parents[0] | ||
|
|
||
|
|
||
| try: | ||
| __version__ = version("{{ cookiecutter.project_slug }}") |
There was a problem hiding this comment.
Suggested change
| __version__ = version("{{ cookiecutter.project_slug }}") | |
| __version__ = version("thera-py") |
korikuzma
reviewed
Jul 15, 2024
| @@ -756,14 +756,14 @@ def test_service_meta(search_handler, normalize_handler): | |||
| response = search_handler.search(query) | |||
| service_meta = response.service_meta_ | |||
| assert service_meta.name == "thera-py" | |||
| assert service_meta.version >= "0.2.13" | |||
| assert service_meta.version != "unknown" | |||
There was a problem hiding this comment.
Ah, I should have done this for disease or gene? I forget which one made this check
There was a problem hiding this comment.
eh I don't really think it matters but at some point we can just run this one around everywhere
korikuzma
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.