feat!: use abstract interface for DB #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
commented
Nov 19, 2023
korikuzma
previously approved these changes
Dec 4, 2023
src/therapy/database/dynamodb.py
Outdated
| def __init__(self, db_url: Optional[str] = None, **db_args) -> None: | ||
| """Initialize Database class. | ||
|
|
||
| :param str db_url: URL endpoint for DynamoDB source |
There was a problem hiding this comment.
Suggested change
| :param str db_url: URL endpoint for DynamoDB source | |
| :param db_url: URL endpoint for DynamoDB source |
src/therapy/database/dynamodb.py
Outdated
Comment on lines
236
to
241
| :param str concept_id: concept ID for therapy record | ||
| :param bool case_sensitive: if true, performs exact lookup, which is more | ||
| efficient. Otherwise, performs filter operation, which doesn't require | ||
| correct casing. | ||
| :param bool merge: if true, look for merged record; look for identity record | ||
| otherwise. |
There was a problem hiding this comment.
Suggested change
| :param str concept_id: concept ID for therapy record | |
| :param bool case_sensitive: if true, performs exact lookup, which is more | |
| efficient. Otherwise, performs filter operation, which doesn't require | |
| correct casing. | |
| :param bool merge: if true, look for merged record; look for identity record | |
| otherwise. | |
| :param concept_id: concept ID for therapy record | |
| :param case_sensitive: if true, performs exact lookup, which is more | |
| efficient. Otherwise, performs filter operation, which doesn't require | |
| correct casing. | |
| :param merge: if true, look for merged record; look for identity record | |
| otherwise. |
src/therapy/database/dynamodb.py
Outdated
| def add_record(self, record: Dict, src_name: SourceName) -> None: | ||
| """Add new record to database. | ||
|
|
||
| :param Dict record: record to upload |
There was a problem hiding this comment.
Suggested change
| :param Dict record: record to upload | |
| :param record: record to upload |
src/therapy/database/dynamodb.py
Outdated
Comment on lines
496
to
499
| :param str term: referent term | ||
| :param str concept_id: concept ID to refer to | ||
| :param str ref_type: one of {'alias', 'label', 'xref', | ||
| 'associated_with'} |
There was a problem hiding this comment.
Suggested change
| :param str term: referent term | |
| :param str concept_id: concept ID to refer to | |
| :param str ref_type: one of {'alias', 'label', 'xref', | |
| 'associated_with'} | |
| :param term: referent term | |
| :param concept_id: concept ID to refer to | |
| :param ref_type: one of {'alias', 'label', 'xref', | |
| 'associated_with'} |
Co-authored-by: Kori Kuzma <korikuzma@gmail.com>
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #343
progress on #254
This PR does similar work as the Postgres PRs for the other normalizers, but just updates the interface and related elements for DynamoDB (postgres will be a future PR, it's been giving me some troubles and I might need to rethink how it was implemented in the other normalizers).