Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add better error messaging #335

Merged
merged 4 commits into from
Sep 26, 2024
Merged

feat: add better error messaging #335

merged 4 commits into from
Sep 26, 2024

Conversation

katiestahl
Copy link
Contributor

@katiestahl katiestahl commented Sep 24, 2024 •
edited
Loading

close #322

  • added error message alert to drag n drop components
  • fixed some loading bugs
  • added clearer formatting for multiple validation errors on Summary tab

@katiestahl katiestahl added enhancement New feature or request priority:medium Medium priority labels Sep 24, 2024
@katiestahl katiestahl self-assigned this Sep 24, 2024
@katiestahl katiestahl mentioned this pull request Sep 24, 2024
Closed
@korikuzma
Copy link
Member

@katiestahl is this one ready or are you going to make a new release in FUSOR and then update this?

@katiestahl
Copy link
Contributor Author

@katiestahl is this one ready or are you going to make a new release in FUSOR and then update this?

oop, I need to make a new fusor release and update the version

@katiestahl
Copy link
Contributor Author

@katiestahl is this one ready or are you going to make a new release in FUSOR and then update this?

oop, I need to make a new fusor release and update the version

done!

korikuzma
korikuzma approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! @jarbesfeld would you be able to test the UI?

jarbesfeld
jarbesfeld approved these changes Sep 26, 2024
View reviewed changes
Copy link

@jarbesfeld jarbesfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@katiestahl katiestahl merged commit 100bb39 into staging Sep 26, 2024
5 checks passed
@katiestahl katiestahl deleted the issue-322 branch September 26, 2024 17:03
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

@jarbesfeld jarbesfeld jarbesfeld approved these changes

@jsstevenson jsstevenson Awaiting requested review from jsstevenson

Assignees

@katiestahl katiestahl

Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katiestahl @korikuzma @jarbesfeld