New parameter i18n override #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilvioC2C
reviewed
Sep 3, 2024
Comment on lines
+203
to
+204
| if not isinstance(override_translations, bool): | ||
| raise ParseError(u"'override_translations' key must be a boolean", YAML_EXAMPLE) |
There was a problem hiding this comment.
Checks are failing because the method receives None for override_translations, and the instance check against bool type fails.
Maybe you can normalize the variable before the check like this:
Suggested change
| if not isinstance(override_translations, bool): | |
| raise ParseError(u"'override_translations' key must be a boolean", YAML_EXAMPLE) | |
| override_translations = override_translations or False | |
| if not isinstance(override_translations, bool): | |
| raise ParseError(u"'override_translations' key must be a boolean", YAML_EXAMPLE) |
or:
Suggested change
| if not isinstance(override_translations, bool): | |
| raise ParseError(u"'override_translations' key must be a boolean", YAML_EXAMPLE) | |
| if override_translations not in (None, True, False): | |
| raise ParseError(u"'override_translations' key must be None or a boolean", YAML_EXAMPLE) |
There was a problem hiding this comment.
But comment taken in account
There was a problem hiding this comment.
I was waiting for a DB migration to complete and I saw this PR, so I took the chance to give it a read even if it was in draft 😄
There was a problem hiding this comment.
Nexyt PR, the good one ^^ #76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.