Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove FUNCS and GPT 3.5 Turbo in examples #938

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Sep 12, 2024

Description

  1. when importing FUNCS all toolkits would be initialized, which may cause errors due to missing API setting, user can make OpenAIFunction by them selves when needed, so we only need to keep toolkits
  2. update gpt-3.5-turbo to gpt-4o-mini in examples, tutorial part would be updated in cookbook PRs

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Sep 12, 2024
@Wendong-Fan Wendong-Fan added the bug Something isn't working label Sep 12, 2024
@Wendong-Fan Wendong-Fan modified the milestone: Sprint 12 Sep 12, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review September 12, 2024 19:31
@Wendong-Fan Wendong-Fan changed the title fix: Make Google maps as optional fix: Remove FUNCS and GPT 3.5 Turbo in examples Sep 13, 2024
@Wendong-Fan Wendong-Fan linked an issue Sep 13, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@WHALEEYE WHALEEYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the overall style of our toolkits is quite chaotic, may need to be refactored later

@Wendong-Fan
Copy link
Member Author

LGTM, but I think the overall style of our toolkits is quite chaotic, may need to be refactored later

I will merge this PR first to solve the issue caused by toolkits api requirement, we can do further enhancement later

@Wendong-Fan Wendong-Fan merged commit c718e0c into master Sep 13, 2024
4 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the google_maps_fix branch September 13, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] OPENAI_API_KEY will be required even though unnecessary
2 participants