Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty track issue #25

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix empty track issue #25

merged 3 commits into from
Dec 27, 2023

Conversation

buraksenkus
Copy link
Contributor

Description

The changes in this pull request fixes empty track issue in _midi_file object is midigen.py.

Fixes #24

Changes and Fixes

  • I've added a new feature (provide details).
  • I've fixed a bug (give a brief explanation of how it was resolved).
  • I've made a breaking change (describe what was changed).
  • I've made an enhancement to an existing feature (describe what was enhanced).

I've removed _track object and used self.midi_file.tracks[0] reference to avoid redundant track store.

How Has This Been Tested?

I've written test_tracks function in test_midigen.py to test my fix. Other tests also pass successfully.

Checklist:

  • My code follows the code style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in areas that may be hard for others to understand.
  • I have updated the documentation to reflect my changes.
  • My changes do not generate new warnings.
  • I have added tests that prove my changes are effective.
  • New and existing unit tests pass locally with my changes.

@cainky
Copy link
Owner

cainky commented Dec 27, 2023

Hello @buraksenkus, thank you very much for your pull request! I was quite pleasantly surprised to see your comments – it is really great to know that others find interest in my repo

I deeply appreciate your initiative in identifying and addressing the issue. Rest assured, I'll review your pull request thoroughly and ensure any necessary fixes are implemented promptly. It's exciting to hear that you plan to use this library in your personal project, and your periodic contributions are most welcome.

Thanks again for your valuable input and support

@cainky cainky self-requested a review December 27, 2023 19:49
Copy link
Owner

@cainky cainky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can work with this! :)

@cainky cainky merged commit a8cffd5 into cainky:main Dec 27, 2023
1 check passed
@buraksenkus buraksenkus deleted the fix-empty-track branch December 28, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid file due to empty track
2 participants