feat: KLogContext #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the class name stays matches with the expect
…ogger into feat/initial-setup
MarkCMann
approved these changes
Jul 25, 2023
| @Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS") | ||
| public actual typealias KLogContext<LOGGER, API> = LogContext<LOGGER, API> | ||
|
|
||
| @Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS") |
There was a problem hiding this comment.
What error is this suppressing? Which member is missing? Could you include a comment about why this needs to be suppressed as well
There was a problem hiding this comment.
The first suppress is for 'errors' regarding the protected visibility: https://youtrack.jetbrains.com/issue/KT-19848
The second suppress is for companion objects - java statics vs companion object is marked as an error.
Both will work if you suppress them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KLogContext to the shared code.
Classes that were not included in this PR
They are tagged as TODO otherwise they will blow up this PR as they also depend on other classes that need to be commonized as well. I will open PRs for those later