Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move linked roles to core package #138

Merged
merged 4 commits into from
Sep 23, 2024
Merged

refactor: move linked roles to core package #138

merged 4 commits into from
Sep 23, 2024

Conversation

apteryxxyz
Copy link
Sponsor Member

@apteryxxyz apteryxxyz commented Sep 21, 2024 •
edited
Loading

Part of #99

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7cfa6cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@buape/carbon Minor
create-carbon Patch
@buape/carbon-nodejs Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added p:carbon The carbon package dependencies Dependency updates!! labels Sep 21, 2024
@apteryxxyz apteryxxyz added blocked Action required to proceed and removed blocked Action required to proceed labels Sep 21, 2024
@apteryxxyz apteryxxyz marked this pull request as ready for review September 22, 2024 08:45
@apteryxxyz apteryxxyz requested a review from a team as a code owner September 22, 2024 08:45
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 22, 2024 •
edited
Loading

Open in Stackblitz

@buape/carbon

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon@138

create-carbon

pnpm add https://pkg.pr.new/buape/carbon/create-carbon@138

@buape/carbon-linked-roles

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon-linked-roles@138

@buape/carbon-nodejs

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon-nodejs@138

@buape/carbon-request

pnpm add https://pkg.pr.new/buape/carbon/@buape/carbon-request@138

commit: 7cfa6cf

thewilloftheshadow
thewilloftheshadow requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@thewilloftheshadow thewilloftheshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but can we tweak the api generation for the docs
CleanShot 2024-09-22 at 10 03 45@2x

@thewilloftheshadow thewilloftheshadow merged commit 6ab721f into buape:main Sep 23, 2024
7 of 9 checks passed
@apteryxxyz apteryxxyz deleted the refactor/move-linked-roles branch September 23, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilloftheshadow thewilloftheshadow thewilloftheshadow approved these changes

Assignees
No one assigned
Labels
dependencies Dependency updates!! p:carbon The carbon package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apteryxxyz @thewilloftheshadow