Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.4.6 #77

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

version 0.4.6 #77

wants to merge 6 commits into from

Conversation

mxmCherry
Copy link

Just security changes since prev version

@dim to merge, tag version, release to rubygems.

Just security changes since prev version
@mxmCherry
Copy link
Author

CI still fails, will see tomorrow. It's mostly up to old ruby, maybe we should just drop it.

@@ -11,9 +11,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ["2.7", "3.0", "3.1", "3.2"]
ruby-version: ["3.0", "3.1", "3.2", "3.3", "3.4"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dim I'm dropping ruby v2. Too much hassle with the deps (mostly dry-XXX indirect deps), there are few dry-XXX packages and their latest versions are requiring ruby v3, I don't want to list and override (downgrade) versions for all of them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I don't know why we enumerate all the minor Ruby versions there + how many last versions should we aim to support, so enumerated all the 3.x available as of today.

@@ -1,32 +1,41 @@
PATH
remote: .
specs:
grape-kaminari (0.4.5)
grape-kaminari (0.5.0)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider dropping major Ruby version support a breaking change.

But this is the only breaking change -- otherwise all the accumulated changes are dep bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants