[DDO-3854] Propagate to FC Microsoft accounts #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
No API changes detected |
mflinn-broad
approved these changes
Aug 21, 2024
katiewelch
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 69.03% 69.03%
=======================================
Files 282 282
Lines 12763 12763
=======================================
Hits 8811 8811
Misses 3050 3050
Partials 902 902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous config would've propagated roles to people's BI Microsoft accounts, but Mike and I think that test.firecloud.org / firecloud.org is actually what we want here.
Role propagation can handle this change so I'm not calling this breaking.
Testing
This is a default config tweak -- there's existing tests for how this suffix gets used and substituted
Risk
Low