[DDO-3848] Add Python client #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No API changes detected |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
=======================================
Coverage 69.23% 69.23%
=======================================
Files 277 277
Lines 12582 12582
=======================================
Hits 8711 8711
Misses 2978 2978
Partials 893 893 |
em-may
approved these changes
Aug 19, 2024
katiewelch
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
sherlock_python_clientinsherlock-python-client/.Looks like Pip supports install from VCS so I'm just calling that good enough for now because the less interaction I have with the Python package system the better.
Testing
I set up a Python environment locally and managed to run the tests that the API generates. I feel like that's kinda unnecessary to actually run in PRs here and it would be a bit annoying -- the Python client is basically an as-is thing.
Risk
Very low -- this doesn't change Sherlock's code at all.