small adjustment to code order and column selection in load_discr_data.R to make it more r… #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obust to csvs with other than isotope columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian,
first of all, thanks for all the effort and work you put in this package. I have a very small but (I hope) helpful suggestion.
If the CSV with discrimination data contains a non-numeric column, load_discr_data() breaks because it converts the data to a matrix without removing non-numeric columns. Especially for non-experienced users the generic "non-numeric argument to binary operator" is not really indicating clearly why the error occurs. A simple rearranging of the code order and selecting only the isotope columns will give the user the flexibility to have also these columns in the discrimination data and not encounter this error anymore. Although I know that another column in the discrimination CSV is rather pointless (but maybe someone wants to store the doi of the reference if TEF is not determined experimentally), I have seen this happen to users which causes unnecessary confusion. All 33 tests were passed with this change.
Kind regards,
Eric