Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assume false on inline 0 #934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Core/Inline.cs
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ private int InlineCallCmd(Block block, CallCmd callCmd, Implementation impl, Lis
else if (options.ProcedureInlining == CoreOptions.Inlining.Assume)
{
// add assume
newCmds.Add(new AssumeCmd(callCmd.tok, Expr.False));
newCmds.Add(new AssumeCmd(callCmd.tok, Expr.True));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an assume true seems pointless. Better to remove the command altogether then.

Copy link
Author

@petemud petemud Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think assert false on inline == 0 also should be assert true or empty

}
else
{
Expand Down