Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring related to https://github.com/boogie-org/boogie/pull/891 #898

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Refactoring related to https://github.com/boogie-org/boogie/pull/891 #898

merged 6 commits into from
Jul 3, 2024

Conversation

keyboardDrummer
Copy link
Collaborator

@keyboardDrummer keyboardDrummer commented Jul 3, 2024 •
edited
Loading

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) July 3, 2024 10:02
atomb
atomb approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the second PR! It looks nice.

Source/VCGeneration/Prune/Prune.cs
var start = controlFlowGraph.TopologicalSort().FirstOrDefault();
var revealedAnalysis = new RevealedAnalysis(start == null ? Array.Empty<Cmd>() : new[] { start },
var starts = controlFlowGraph.Nodes.Where(n => !controlFlowGraph.Predecessors(n).Any()).ToList();
var revealedAnalysis = new RevealedAnalysis(starts,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer. :)

@keyboardDrummer keyboardDrummer merged commit 7b89e1e into boogie-org:master Jul 3, 2024
5 checks passed
@keyboardDrummer keyboardDrummer deleted the refactoring891 branch July 3, 2024 18:34
@keyboardDrummer keyboardDrummer mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyboardDrummer @atomb