Modernize package manager dialog #1969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
force-pushed
the
issue-1965
branch
from
ca98110
to
c2071ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package manager dialog has suffered a few changes over the years to support modern NuGet client features. However, this modernization was never finalized and there are still important features of modern NuGet clients which are not included.
This PR updates the styling and functionality of the package manager dialog to display deprecation warnings and latest version strings for all packages inline with the package title, as well as package authors, total package download counts, and package prefix reservation icons. Package operation buttons were replaced with fixed size icons.
A number of changes were required to get the layout to work properly, the most significant of which is adding interactive highlighting to the operation button which is now more important as a call to action. Spacing between package descriptions and various other small layout issues were also fixed.
Operation buttons were included in package details for all actions, including package updates and opening gallery example packages, and support was added for selecting the exact package version.
Finally, a dedicated dialog for viewing embedded license files in local packages was added to resolve #957. This required a refactoring to the internal license acceptance events and dialog. Modern package servers will serve embedded license files and provide the URL in the package search metadata so we will not worry with the remote case.
Filtering for gallery and library packages was added by default to resolve #1603, with a checkbox enabling search for all dependency package types if necessary.
Fixes #1603
Fixes #1965
Fixes #957