Replace uses of WebRequest with HttpClient #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
added
feature
PathogenDavid
requested changes
Jul 24, 2024
PathogenDavid
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WebRequestAPI has sadly been deprecated by the more performantHttpClientin modern .NET. As this API is also available in .NET Framework, this PR aligns the two code bases by replacing all instances ofWebRequestwith an alternative implementation usingHttpClient.There were two main uses of
WebRequestin the current source code:Each of these is addressed separately, as the reimplementation is quite specific for each case. An opportunity was taken to refactor package icon retrieval away from UI code to improve separation of concerns.
Fixes #1936