Log full exception trace for console bootstrap #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the console bootstrapper behavior to ensure the full exception stack trace is dumped to the logger in the event of an error. The motivation is to improve the debugging experience in terminal-only environments where visualization and exploring of networking and authentication issues may be complicated.
The original bug report suggested throwing at the top-level application, but this may have knock-on effects on the inter-process communication underlying the bootstrapper logic and when calling the Bonsai process from other applications, so it is avoided by having a more verbose log behavior at the level of the specific bootstrapper.
Fixes #1804