Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator to query an environment variable #1232

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Add operator to query an environment variable #1232

merged 5 commits into from
Jul 5, 2023

Conversation

bruno-f-cruz
Copy link
Contributor

This PR attempts to close #1231.

  • Adds an operator to query an environment variable to Bonsai.System.IO.

glopesdev
glopesdev requested changes Jul 5, 2023
View reviewed changes
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
glopesdev
glopesdev requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@glopesdev glopesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sounds great, just a minor edit pending.

Bonsai.System/IO/GetEnvironmentVariable.cs Outdated Show resolved Hide resolved
@glopesdev glopesdev merged commit cab951e into bonsai-rx:main Jul 5, 2023
2 checks passed
@bruno-f-cruz bruno-f-cruz deleted the issue-1231 branch July 5, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glopesdev glopesdev glopesdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add operator to query os environment variables
2 participants
@bruno-f-cruz @glopesdev