Drop version build metadata for official releases

bonsai-rx · Jul 16, 2024 · 1b22753 · 1b22753
1 parent 3464e65
commit 1b22753
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/Bonsai.Core/WorkflowBuilder.cs b/Bonsai.Core/WorkflowBuilder.cs
@@ -200,8 +200,14 @@ void IXmlSerializable.WriteXml(XmlWriter writer)
             writer = new XmlExtensionWriter(writer, genericTypes);
 
             var assembly = Assembly.GetExecutingAssembly();
-            var versionInfo = FileVersionInfo.GetVersionInfo(assembly.Location);
-            writer.WriteAttributeString(VersionAttributeName, versionInfo.ProductVersion);
+            var version = FileVersionInfo.GetVersionInfo(assembly.Location).ProductVersion;
+#if BUILD_KIND_OFFICIAL_RELEASE
+            // Drop build metadata for official releases
+            var plus = version.IndexOf('+');
+            if (plus >= 0)
+                version = version.Substring(0, plus);
+#endif
+            writer.WriteAttributeString(VersionAttributeName, version);
 
             var namespaceDeclarations = GetXmlSerializerNamespaces(types);
             foreach (var qname in namespaceDeclarations)

diff --git a/Bonsai.Editor/AboutBox.cs b/Bonsai.Editor/AboutBox.cs
@@ -60,7 +60,12 @@ public string AssemblyVersion
         {
             get
             {
-                return FileVersionInfo.GetVersionInfo(Assembly.GetExecutingAssembly().Location).ProductVersion;
+                var productVersion = FileVersionInfo.GetVersionInfo(Assembly.GetExecutingAssembly().Location).ProductVersion;
+#if BUILD_KIND_OFFICIAL_RELEASE
+                return SemanticVersion.Parse(productVersion).ToString();
+#else
+                return productVersion;
+#endif
             }
         }