Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetBiosConfiguration(ctx, biosConfig) & ResetBiosConfiguration(ctx) for dell #385

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

splaspood
Copy link
Collaborator

What does this PR implement/change/remove?

This PR adds support for setting BIOS configuration values via the redfishwrapper on Dell platforms. Additionally, the ability to perform a 'factory reset' of the BIOS configuration, also for Dell platforms, is included.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

Dell

Description for changelog/release notes

Adds SetBiosConfiguration() and ResetBiosConfiguration() to the dell provider.

@splaspood
Copy link
Collaborator Author

Pending addition of ResetBiosConfiguration() functionality, and tests.

@splaspood
Copy link
Collaborator Author

Added ResetBiosConfiguration() functionality. Working up some testing now..

coffeefreak101
coffeefreak101 previously approved these changes Apr 15, 2024
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, mind adding in an example?

edit: never mind, I see the example added in 1ac1d69

bmc/bios.go Outdated Show resolved Hide resolved
@splaspood
Copy link
Collaborator Author

Nice work, mind adding in an example?

There is one, examples/bios exercises GetBiosConfiguration(), SetBiosConfiguration() and ResetBiosConfiguration()

@splaspood splaspood merged commit a3d8e72 into main Apr 16, 2024
5 checks passed
@splaspood splaspood deleted the bios-config-0 branch April 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants