Move to pyright and fix type errors #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 96.25% 96.05% -0.20%
==========================================
Files 9 9
Lines 935 939 +4
==========================================
+ Hits 900 902 +2
- Misses 35 37 +2 ☔ View full report in Codecov by Sentry. |
callumforrester
force-pushed
the
103_pyright
branch
3 times, most recently
from
112d5e7
to
44f3b10
Compare
coretl
approved these changes
Aug 16, 2024
src/scanspec/core.py
Outdated
| @@ -616,7 +616,7 @@ def consume(self, num: int | None = None) -> Frames[Axis]: | |||
|
|
|||
| def __len__(self) -> int: | |||
| """Number of frames left in a scan, reduces when `consume` is called.""" | |||
| return self.end_index - self.index | |||
| return int(self.end_index - self.index) | |||
There was a problem hiding this comment.
Nit: if we define self.end_index: int = np.prod... then we shouldn't have to do this?
There was a problem hiding this comment.
That still requires a cast when I try it...
There was a problem hiding this comment.
In the end I went with self.end_index = int(np.prod(self.lengths)), since that fixes another error that emerged with a pyright upgrade
ZohebShaikh
reviewed
Aug 16, 2024
pyproject.toml
Outdated
| "click>=8.1", | ||
| "pydantic>=2.0", | ||
| ] | ||
| dependencies = ["numpy>=2", "click>=8.1", "pydantic>=2.0"] |
There was a problem hiding this comment.
numpy needs to be unpinned
callumforrester
force-pushed
the
103_pyright
branch
from
44f3b10
to
2527d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103