added more tests

src/scanspec/core.py

@@ -135,32 +135,10 @@ def uses_tagged_union(cls_or_func: T) -> T:
     Decorator that processes the type hints of a class or function to detect and
     register any tagged unions. If a tagged union is detected in the type hints,
     it registers the class or function as a referrer to that tagged union.
-
     Args:
         cls_or_func (T): The class or function to be processed for tagged unions.
-
     Returns:
         T: The original class or function, unmodified.
-
-    The function works by iterating over the type hints of the provided class or
-    function For each type hint, it checks if the type (or its origin,
-    in the case of generic types) is registered as a tagged union in the
-    global `_tagged_unions` dictionary. If a match is found, the
-    tagged union's `add_referrer` method is called to register the class
-    or function as a referrer.
-
-    Example:
-            class PointsRequest:
-            A request for generated scan points
-                spec: Spec
-        This will register `PointsRequest` and `Spec` with the corresponding tagged
-        union or
-            @uses_tagged_union
-            def valid(
-            spec: Spec = Body(..., examples=[_EXAMPLE_SPEC]),
-            ) -> ValidResponse | JSONResponse:
-            The decorator helps pydantic in understanding the core schema for the
-            function
     """
     for k, v in get_type_hints(cls_or_func).items():
         tagged_union = _tagged_unions.get(get_origin(v) or v, None)
@@ -198,8 +176,7 @@ def add_member(self, cls: type):
             # called muliple times for the same member, do no process if it wouldn't
             # change the member list
             return
-        if cls is self._base_class:
-            return
+
         self._members.append(cls)
         union = self._make_union()
         if union:

src/scanspec/regions.py

@@ -1,8 +1,8 @@
 from __future__ import annotations
 
-from collections.abc import Iterator
-from dataclasses import is_dataclass
-from typing import Generic
+from collections.abc import Iterator, Mapping
+from dataclasses import asdict, is_dataclass
+from typing import Any, Generic
 
 import numpy as np
 from pydantic import BaseModel, Field
@@ -66,6 +66,10 @@ def __sub__(self, other) -> DifferenceOf[Axis]:
     def __xor__(self, other) -> SymmetricDifferenceOf[Axis]:
         return if_instance_do(other, Region, lambda o: SymmetricDifferenceOf(self, o))
 
+    def serialize(self) -> Mapping[str, Any]:
+        """Serialize the Region to a dictionary."""
+        return asdict(self)  # type: ignore
+
     @staticmethod
     def deserialize(obj):
         """Deserialize the Region from a dictionary."""

src/scanspec/specs.py

@@ -511,7 +511,7 @@ def bounded(
 
 
 """
-Validation Decorator is requied as we are using custom pydantic core schema validators
+Defers wrapping function with validate_call until class is fully instantiated
 """
 Line.bounded = validate_call(Line.bounded)  # type:ignore
 

tests/test_serialization.py

@@ -4,7 +4,7 @@
 import pytest
 from pydantic import ValidationError
 
-from scanspec.regions import Circle, Rectangle, UnionOf
+from scanspec.regions import Circle, Rectangle, Region, UnionOf
 from scanspec.specs import Line, Mask, Spec, Spiral
 
 
@@ -15,6 +15,20 @@ def test_line_serializes() -> None:
     assert Spec.deserialize(serialized) == ob
 
 
+def test_circle_serializes() -> None:
+    ob = Circle("x", "y", x_middle=0, y_middle=1, radius=4)
+    serialized = {
+        "x_axis": "x",
+        "y_axis": "y",
+        "x_middle": 0.0,
+        "y_middle": 1.0,
+        "radius": 4.0,
+        "type": "Circle",
+    }
+    assert ob.serialize() == serialized
+    assert Region.deserialize(serialized) == ob
+
+
 def test_masked_circle_serializes() -> None:
     ob = Mask(Line("x", 0, 1, 4), Circle("x", "y", x_middle=0, y_middle=1, radius=4))
     serialized = {