[MOBL-1399] Events module rewrite in Kotlin language #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrvp
commented
Jul 29, 2024
|
|
||
| return result; | ||
| BlueshiftNetworkRepositoryImpl networkRepository = new BlueshiftNetworkRepositoryImpl(); |
There was a problem hiding this comment.
If the line crashes, the catch block will be able to catch the exception and print the log.
rahulrvp
commented
Jul 29, 2024
| BulkEventManager.enqueueBulkEvents(context); | ||
| // Sync the http request queue. | ||
| RequestQueue.getInstance().sync(context); | ||
| }); |
There was a problem hiding this comment.
Keeping a flag to check if the queue was emptied before is a bit tricky and won't give accurate answer all the time. Both these calls have internal checks to make sure we are not running into expensive operations if the queue is empty.
…n tracking is disabled.
…tworkRequestRepositoryImpl
rahulrvp
commented
Aug 6, 2024
| fun setDatacenter_whenSetToEU_shouldReturnCorrectURLForAllAPIsWithEUBaseUrl() { | ||
| BlueshiftAPI.setDatacenter(BlueshiftAPI.Datacenter.EU) | ||
|
|
||
| val baseUrlForUS = "https://api.eu.getblueshift.com/" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event module is rewritten using Kotlin for an improved structure and performance. This code is covered with test cases.