Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBL-1776] Improved security by replacing SharedPreferences with EncryptedSharedPreferences to store UserInfo #357

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

rahulrvp
Copy link
Collaborator

@rahulrvp rahulrvp commented May 6, 2024

With this change, the SDK will start using the EncryptedSharedPreferences instead of SharedPreferences to store the user info locally. This will prevent attackers from reading personal information such as email, phone number, name, etc stored as plain text in the XML file.

@rahulrvp rahulrvp self-assigned this May 6, 2024
Copy link

@ketanshikharebsft ketanshikharebsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulrvp rahulrvp merged commit b631c90 into dev Jun 4, 2024
1 check passed
@rahulrvp rahulrvp deleted the mobl-1776-encrypted-sp branch June 4, 2024 05:56
rahulrvp added a commit that referenced this pull request Jun 13, 2024
…ryptedSharedPreferences to store UserInfo (#357)

* [MOBL-1811] Gradle = 8.6, AGP = 8.4.0, Kotlin = 1.9.23, targetSdkVersion = 34

* Reverting an unwanted version change

* first draft of encrypted shared pref implementation is ready

* Added tests for the get and save methods

* Added code for migration when needed.

* Added test cases to make sure the new preference is backward compatible

* Deprecated the clear(context) method

* Added additional test case

* Added configuration variable to opt in for encryption feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants