[MOBL-1809] AGP version updated to 7.4.2 and enabled Kotlin (version 1.9.0) for the android-sdk module #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +127,7 @@ private static void buildAndShowNotification(Context context, Message message) { | |||
| // Set the large icon to match the big picture. | |||
| builder.setLargeIcon(bitmap); | |||
| // Hide the large icon when the notification is expanded. | |||
| bigPictureStyle.bigLargeIcon(null); | |||
| bigPictureStyle.bigLargeIcon((Bitmap) null); | |||
There was a problem hiding this comment.
is it possible to pass the values like this?
There was a problem hiding this comment.
The problem: The bigLargeIcon method takes one argument and that can be either a Bitmap or an Icon object. Passing null creates confusion for the compiler. It won't know which method signature to use.
The solution: Cast the null to Bitmap or Icon and avoid confusion to the compiler.
Will it crash? - No. Java 17 allows you to cast null to any other object. However, it won't make a real Bitmap object. It will still be a null reference.
rahulrvp
added a commit
that referenced
this pull request
Jun 13, 2024
…1.9.0) for the android-sdk module (#355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?