New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow provision type omit empty in worker pool struct #174

Merged

greatbn merged 1 commit into master from hotfix/bke-allow-empty-provision-type

Feb 21, 2024

Contributor

chpiano2000 commented Feb 20, 2024

Bizfly terraform client hiện đang không support trường ProvisionType cho worker và cluster
Trong body create cluster của gobizfly có trường này. Vấn đề ở đây là phía bke-api nếu không truyền trường này thì không sao. Nhưng có truyền mà sai value thì sẽ lỗi validate. Vậy nên chủ động set omit empty cho trường ProvisionType này để backward compatible với Bizfly terraform client


          fix: allow provision type omit empty in worker pool struct

9c117f3

greatbn approved these changes

View reviewed changes

greatbn merged commit e583889 into master

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet