Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting MaxPaths, EcmpOnly and BestOnly for ObserveRIB request #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

netixx
Copy link
Contributor

@netixx netixx commented Apr 18, 2024

Solves github.com//issues/466 for the ris server part.

Solves github.com/bio-routing/issues/466 for the ris server part.

Signed-off-by: netixx <francois.espinet@ovhcloud.com>
@netixx
Copy link
Contributor Author

netixx commented Apr 18, 2024

Something looks wrong with the codecov action atm...

@@ -58,6 +65,7 @@ message ObserveRIBRequest {
}
AFISAFI afisafi = 3;
bool allow_unready_rib = 5;
optional ObserveRIBOptions observe_options = 6; // additional options for the observe request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're just not extending the ObserveRIBRequest instead of defining another message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants