Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gRPC Routing Protocol #445

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

BarbarossaTM
Copy link
Member

As we decided not to go forward with #416, clean up residual bits from this approach.

@BarbarossaTM BarbarossaTM added the type:clean-up Code clean-up label Aug 22, 2023
@BarbarossaTM BarbarossaTM self-assigned this Aug 22, 2023
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
@codecov-commenter
Copy link

Codecov Report

Merging #445 (38e7126) into master (f71bc38) will increase coverage by 0.26%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   54.03%   54.30%   +0.26%     
==========================================
  Files         147      146       -1     
  Lines        7963     7894      -69     
==========================================
- Hits         4303     4287      -16     
+ Misses       3455     3401      -54     
- Partials      205      206       +1     
Flag Coverage Δ
unittests 54.30% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
route/path.go 85.79% <ø> (+5.79%) ⬆️
route/route.go 87.59% <ø> (ø)
route/static.go 64.28% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BarbarossaTM BarbarossaTM changed the title Remove gRPC Routing Protocol proto Remove gRPC Routing Protocol Aug 22, 2023
@taktv6 taktv6 merged commit 2f55bf4 into bio-routing:master Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:clean-up Code clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants