Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STRF-11834 Consolidate css assembling logic #117

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Sep 17, 2024

Jira: STRF-11834

What/Why?

Taken from https://github.com/bigcommerce/stencil-cli/blob/master/lib/css-assembler.js
Added unit tests
Added PR template

Rollout/Rollback

Revert PR

Testing

unit tests

@jairo-bc jairo-bc force-pushed the STRF-11834 branch 3 times, most recently from dcd452f to 3a8ca00 Compare September 17, 2024 12:16
@jairo-bc jairo-bc requested a review from a team September 17, 2024 12:42
@jairo-bc jairo-bc changed the title feat: STRF-11834 Consolidate css assembling logic ref: STRF-11834 Consolidate css assembling logic Sep 17, 2024
@jairo-bc jairo-bc changed the title ref: STRF-11834 Consolidate css assembling logic feat: STRF-11834 Consolidate css assembling logic Sep 17, 2024
Copy link

@jmwiese jmwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jairo-bc jairo-bc merged commit 0166309 into master Sep 17, 2024
5 checks passed
@jairo-bc jairo-bc mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants