Extend Dockerfile with additional labels #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
reviewed
Sep 28, 2023
|
was also looking for the arg stuff. might be a thing, looks easy enough atm |
|
will update this pr after this is merged: |
|
@rwaffen should we merge this as is and do a release? |
|
we can merge this, but need to work on the upstream gha to allow us to set the tag manually. atm tags are set automatically when you push to main (development) or when you push a tag (v1.2.3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on https://github.com/puppetlabs/bolt-vanagon/blob/main/docker/puppet-bolt/Dockerfile. The ARG stuff from the bolt Dockerfile might be a nice way to build for Puppet 7 and 8?