Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull version #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pull version #2

wants to merge 2 commits into from

Conversation

Ariavm95
Copy link

Hi. As you can see, my version is cleaner than the version you updated 2 days ago. For example, these are not a valid data: "author": "From a Tablet of Bahá’u’lláh" and "source": "1992 Dec 10".

Ariavm95 added 2 commits July 25, 2015 01:42
Updated JSON by Aria
Updated JSON
@bchurchill
Copy link
Owner

The previous version had tags on them. Would you be willing to add these?

I'm thinking that, after I merge this in, I'm going to try to separate different sources for quotes into different files. For example, there would be one file for all the bahaiquotes.com ones. Down the road, people could choose different source formats for different collections. I'm going to open a ticket for this.

@adibbehjat
Copy link
Contributor

Not sure how valuable it'll be to create a separate page for the quotes. I think a better solution would be creating a platform that checks whether a quote exists already - and if it doesn't, it'll create a new node for the new quote added.

@bchurchill
Copy link
Owner

Let's move this discussion to #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants