Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle data api project #1690

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Oracle data api project #1690

merged 9 commits into from
Mar 20, 2024

Conversation

pbolduc
Copy link
Contributor

@pbolduc pbolduc commented Mar 20, 2024

Description

This PR includes the following proposed change(s):

  • Adds TrafficCourts.OracleDataApi project for all generated code. Note there is a out standing PR for NSwag that prevents us from running the NSwag at compile time - Allow setting of the client interface access modifier based on the model access modifier RicoSuter/NSwag#4820
  • Removes remainingOpenAPIs.OracleDataApi.v1_0 references replacing with TrafficCourts.Domain.Models
  • Changes uses of IOracleDataApiClient with IOracleDataApiService
  • Moved UserIdentityProviderHandler from Common to Staff API
  • Regenerated the staff portal and client portal. Only change was a move of a couple of properties
  • Adds the paging stuff required by staff portal paging

No caching was added
No changes to APIs (staff api / citizen api)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Run

Does the change impact or break the Docker build?

  • Yes
  • No

If Yes: Has Docker been updated accordingly?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@pbolduc pbolduc merged commit e6ee79a into main Mar 20, 2024
5 checks passed
@pbolduc pbolduc deleted the oracle-data-api-project branch March 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants