Skip to content

Commit

Permalink
Remove column number arg from 'action open'
Browse files Browse the repository at this point in the history
  • Loading branch information
bbugyi200 committed Mar 12, 2024
1 parent bcb1687 commit a972cc6
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 18 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ The format is based on [Keep a Changelog], and this project adheres to

## [Unreleased](https://github.com/bbugyi200/zorg/compare/0.4.0...HEAD)

No notable changes have been made.
### Changed

* *BREAKING CHANGE*: Removed `zorg action open` command's column number
positional argument.


## [0.4.0](https://github.com/bbugyi200/zorg/compare/0.3.0...0.4.0) - 2024-03-11
Expand Down
12 changes: 5 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,19 +125,17 @@ subcommands:
The output from running `zorg action open --help` is shown below:

```
usage: zorg action open [-h] zo_path line_number column_number
usage: zorg action open [-h] zo_path line_number
Open a zettel link if one exists on the provided zorg file line.
positional arguments:
column_number The column number that your editor cursor is currently
located on.
line_number The line number that your editor cursor is currently located
on.
zo_path The file that your editor currently has open.
line_number The line number that your editor cursor is currently located
on.
zo_path The file that your editor currently has open.
options:
-h, --help show this help message and exit
-h, --help show this help message and exit
```

The output from running `zorg db --help` is shown below:
Expand Down
9 changes: 0 additions & 9 deletions src/zorg/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class OpenActionConfig(Config):

zo_path: Path
line_number: int
column_number: int


class DbInfoConfig(Config):
Expand Down Expand Up @@ -133,14 +132,6 @@ def clack_parser(argv: Sequence[str]) -> dict[str, Any]:
"The line number that your editor cursor is currently located on."
),
)
action_open_parser.add_argument(
"column_number",
type=int,
help=(
"The column number that your editor cursor is currently"
" located on."
),
)

# --- 'db' command
db_parser = new_command(
Expand Down
1 change: 0 additions & 1 deletion tests/test_action_open_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ def test_action_open(
"open",
str(zpath_to_links),
str(lineno),
"1",
)

assert exit_code == 0
Expand Down

0 comments on commit a972cc6

Please sign in to comment.