feat: nlohmann_json add single_include package #2865
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @keith, modules you maintain (nlohmann_json) have been updated in this PR. Please review the changes. |
lromor
changed the title
lromor
force-pushed
the
add-nlohmann-json-multi-header
branch
6 times, most recently
from
25ff0a3
to
106bfb5
Compare
lromor
changed the title
|
I'd put it in the toplevel BUILD file. Keep the original Reasoning: for projects that also support the 'old' WORKSPACE file, they have a simple way to provide a toplevel BUILD file, but not a nested structure. A project that needs to compile with before and after bzlmod should be able to do that easily. Example of such a project and how it will be working nicely with a toplevel target : chipsalliance/verible#2268 |
lromor
force-pushed
the
add-nlohmann-json-multi-header
branch
from
106bfb5
to
7b71bd4
Compare
lromor
force-pushed
the
add-nlohmann-json-multi-header
branch
from
7b71bd4
to
a26590b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlohmann_json provides a new single-header target. Add it as optional target to the the bazel module.