Improve expiration headers handling for GS64

Improve RESTfulAPIClient put methods to always return a response object
ba-st · Feb 27, 2024 · 53cec0f · 53cec0f
1 parent 710dfe2
commit 53cec0f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/source/Superluminal-RESTfulAPI/ExpiringResource.class.st b/source/Superluminal-RESTfulAPI/ExpiringResource.class.st
@@ -104,7 +104,7 @@ ExpiringResource >> withExpirationDo: ifPresentBlock ifNone: noneBlock [
 	^ [
 	  ifPresentBlock value:
 		  ( self expirationDateApplyingCacheControlDirectivesIfNone: [ self expires ] ) ]
-		  on: NotFound , SubscriptOutOfBounds
+		  on: NotFound , SubscriptOutOfBounds , CollectionIsEmpty
 		  do: [ :ex | ex return: noneBlock value ]
 ]
 

diff --git a/source/Superluminal-RESTfulAPI/RESTfulAPIClient.class.st b/source/Superluminal-RESTfulAPI/RESTfulAPIClient.class.st
@@ -268,13 +268,13 @@ RESTfulAPIClient >> postAt: aLocation configuredBy: aRequestBuildingBlock withSu
 { #category : 'private - inkoving' }
 RESTfulAPIClient >> processPutResponse: response at: aLocation whenSuccessfulDo: aBlock [
 
-	response isSuccess
-		then: [ 
-			expiringCache clearResourceAt: aLocation.
-			^ response isNoContent
-				then: [ response ]
-				otherwise: [ aBlock value: ( self tryToCacheContentsOf: response basedOn: aLocation ) ]
-			].
+	response isSuccess then: [
+		expiringCache clearResourceAt: aLocation.
+		[
+		aBlock value:
+			(self tryToCacheContentsOf: response basedOn: aLocation) ] unless:
+			response isNoContent.
+		^ response ].
 
 	^ self signalCannotCompleteUpdateErrorBasedOn: response
 ]