Skip to content

Commit

Permalink
fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
a-khaledf committed Jun 19, 2024
1 parent 2d3aa88 commit 6b8cfd8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions cloudwatch-ingester-axiom-cloudformation-stack.template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@ Conditions:
- ""
Resources:
"Fn::ForEach::SubscriptionFilters":
- groupName
- GroupName
- !Ref CloudWatchLogGroupNames
- "lgsf&{groupName}":
- "LGSF&{GroupName}":
Type: AWS::Logs::SubscriptionFilter
Condition: HasCloudWatchLogGroupNames
Properties:
DestinationArn: !GetAtt
- LogsLambda
- Arn
FilterPattern: ""
LogGroupName: !Ref groupName
LogGroupName: !Ref GroupName
LogsRole:
Type: AWS::IAM::Role
Properties:
Expand Down Expand Up @@ -86,9 +86,9 @@ Resources:
DISABLE_JSON: !Ref DisableJSON
DATA_TAGS: !Ref DataTags
"Fn::ForEach::LambdaPermissions":
- groupName
- GroupName
- !Ref CloudWatchLogGroupNames
- "LogsLambdaPermission&{groupName}":
- "LogsLambdaPermission&{GroupName}":
Type: AWS::Lambda::Permission
Condition: HasCloudWatchLogGroupNames
DependsOn:
Expand All @@ -104,7 +104,7 @@ Resources:
- "arn:aws:logs:${Region}:${AccountID}:log-group:${LogGroupName}:*"
- AccountID: !Ref "AWS::AccountId"
Region: !Ref "AWS::Region"
LogGroupName: !Ref groupName
LogGroupName: !Ref GroupName
Outputs:
LogsLambdaARN:
Description: The ARN of the created Ingester Lambda
Expand Down

0 comments on commit 6b8cfd8

Please sign in to comment.