Fix bug in MinLength and MaxLength when NullBehavior.EmptyString #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior.EmptyString option, the where filter wasn't properly applied
eycho-am
added a commit
that referenced
this pull request
Feb 26, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
eycho-am
added a commit
that referenced
this pull request
Feb 26, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
…vior.EmptyString option, the where filter wasn't properly applied (#538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
MaxLengthorMinLengthanalyzers with theNullBehavior.EmptyStringanalyzer option, we weren't properly emitting metrics when using a where filter.filterwas not properly applied to constructing the criterion.MaxLengthandMinLengthanalyzers and adds tests to verify.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.