Allow all DQ constraints to be generated from an Analyzer #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsharma26
approved these changes
Oct 6, 2023
eycho-am
pushed a commit
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
eycho-am
pushed a commit
to eycho-am/deequ
that referenced
this pull request
Oct 24, 2023
Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
javierdlrm
pushed a commit
to javierdlrm/deequ
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Due to our typing system, it is always possible to create an Analyzer, but converting that into a generic Constraint and generic Check is impossible.
Instead, give callers the option to convert an Analyzer into a Check with these helper functions. This enables reuse of Analyzers - you can use an Analyzer directly, or convert it to a Check by assigning it a severity and assertion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.