Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DescribeTags retry on high-frequency and delay refresh interval #1344

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

zhihonl
Copy link
Contributor

@zhihonl zhihonl commented Sep 10, 2024

Description of the issue

There was an issue with agent users retrying EC2 DescribeTag API calls on a high frequency and causing throttle errors. The agent also retry on non-throttle errors which is not a recommended behavior

Description of changes

For DescribeTags API calls, follow the behavior below:

  • Successful Calls - Retry every hour
  • Throttling Error - Retry 3 times on an exponential backoff of 0, 60, 180 seconds
  • Other errors - Do not retry

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Unit tests

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@zhihonl zhihonl requested a review from a team as a code owner September 10, 2024 17:57
@zhihonl zhihonl merged commit 44fdf6c into main Sep 10, 2024
6 checks passed
@zhihonl zhihonl deleted the ec2info-fix branch September 10, 2024 20:22
dchappa added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants