[Chore] Added Cleanup for Launch Configurations #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
reviewed
Sep 4, 2024
…on-cloudwatch-agent into fix-clean-launch-config
jefchien
previously approved these changes
Sep 4, 2024
mitali-salvi
previously approved these changes
Sep 4, 2024
…on-cloudwatch-agent into fix-clean-launch-config
okankoAMZ
dismissed stale reviews from mitali-salvi and jefchien
via
b90ea55
|
This PR was marked stale due to lack of activity. |
Paramadon
approved these changes
Sep 19, 2024
musa-asad
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently we do not clean-up after launch configurations are used by our integration test. This leads to waste of resources and also failures in integration test due to maximum amount of launch configurations being reached.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
I ran
go run ./clean_launch_configuration/clean_launch_configuration.go(added a break so it only deletes one) and it deleted the launch configurations.Before the test:
After the test:
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint