Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - S3 to EventBridge to SNS #1443

Conversation

MakendranG
Copy link
Contributor

@MakendranG MakendranG commented Jun 30, 2023

Issue #1444, if available:

Description of changes:

This template creates an S3 bucket that publishes events to Amazon EventBridge, allows you to upload objects to that bucket, and will send you notifications from EventBridge to SNS when an object is created in that bucket.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

@MakendranG your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. language: language is not one of enum values: TypeScript,Node.js,Python,Java,Go,Rust,.NET,OpenAPI,YAML
  2. framework: framework is not one of enum values: CDK,SAM,Terraform,Serverless Framework,Terraform (with modules),Pulumi

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@MakendranG
Copy link
Contributor Author

MakendranG commented Jul 4, 2023

@mavi888 @bls20AWS

Requested changes has been made.

@julianwood
Copy link
Contributor

Thanks for the submission but SAM and Cloudformation are too similar to have separate patterns. The previous pattern you submitted is great for both use-cases: 444ad23
If there is a enough of a difference, feel free to raise again.

@julianwood julianwood closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants