Avoid using default exports #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
reviewed
Jul 31, 2023
jonkoops
suggested changes
Jul 31, 2023
rollup.config.ts
Outdated
| @@ -17,7 +17,7 @@ const plugins = [ | |||
| ]; | |||
|
|
|||
| export default defineConfig([{ | |||
| input: "lib/index.standalone.ts", | |||
| input: "lib/index.ts", | |||
There was a problem hiding this comment.
Since the input is now the same for all files, we can put it in a variable so it can be re-used.
|
Actually have some things that can go into this PR, let me create some changes. |
|
See #176 |
4 tasks
|
I am going to take a look and see if we can somehow keep the UMD bundle compatible. I agree that we should avoid breaking this if possible. |
|
@frederikprijck created #181 to handle this, I think for the sake of backwards compatibility keeping a separate index for UMD is alright. The named exports API also seems really quirky for this one. |
|
@frederikprijck @adamjmcgrath shall we merge this in so work can continue on #174? |
ewanharris
approved these changes
Aug 1, 2023
Merged
frederikprijck
added a commit
that referenced
this pull request
Oct 27, 2023
Co-authored-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Ewan Harris <ewan.harris@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops the default exports, both from the internal and the external API.
This should simplify support for CJS and ESM, see #174 .
Checklist